| Summary: | Add console message when legacy TLS is used | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aakash_jain, cdumez, darin, ews-watchlist, japhet, mkwst, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Christensen
2020-03-23 15:48:19 PDT
Created attachment 394314 [details]
Patch
Comment on attachment 394314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394314&action=review > Source/WebCore/loader/ResourceLoader.cpp:511 > document->setUsedLegacyTLS(true); Could have put that inside the braces. Created attachment 394320 [details]
Patch
Comment on attachment 394320 [details]
Patch
Done. I also removed the host from the logs.
Comment on attachment 394320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394320&action=review > Source/WebCore/loader/ResourceLoader.cpp:509 > + page->console().addMessage(MessageSource::Network, MessageLevel::Warning, "Loaded resource using TLS 1.0 or 1.1, which are deprecated protocols that will be removed. Please use TLS 1.2 or newer instead."_s, 0, document); Two spaces after a period!? Not sure what our style is, but I never do that. Created attachment 394321 [details]
Patch
Our style doesn't seem to care. I've done it consistently since elementary school unless told otherwise, but I removed it here. Committed r258890: <https://trac.webkit.org/changeset/258890> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394321 [details]. Comment on attachment 394321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394321&action=review > Source/WebCore/loader/ResourceLoader.cpp:505 > if (r.usedLegacyTLS()) { > if (m_frame) { Just noticed we could indent this a little bit less by using && here. Reopening to attach new patch. Created attachment 394380 [details]
Patch
commit-queue failed to commit attachment 394380 [details] to WebKit repository.
(In reply to EWS from comment #13) > commit-queue failed to commit attachment 394380 [details] to WebKit repository. There was another commit (modifying same ChangeLog) https://trac.webkit.org/r258916 almost at the same time when commit-queue tried to land this. Please cq+ again. Committed r258957: <https://trac.webkit.org/changeset/258957> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394380 [details]. |