Bug 209433

Summary: Web Inspector: REGRESSION(r257791): WebSocket icon is missing
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Jon Davis <jond>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
URL: https://devinrousso.com/dots/
Bug Depends on: 208458    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
WebSocket Icon in Dark Mode
none
WebSocket Icon in Light Mode
none
Patch none

Description Devin Rousso 2020-03-23 12:31:06 PDT 
# STEPS TO REPRODUCE:
1. inspect <https://devinrousso.com/dots/>
2. go to the Sources Tab
 => the icon next to the `websocket` resource is missing :(
Comment 1 Jon Davis 2020-03-30 17:58:21 PDT 
Created attachment 394994 [details]
Patch
Comment 2 Jon Davis 2020-03-30 17:59:51 PDT 
Created attachment 394995 [details]
WebSocket Icon in Dark Mode
Comment 3 Jon Davis 2020-03-30 18:00:05 PDT 
Created attachment 394996 [details]
WebSocket Icon in Light Mode
Comment 4 Joseph Pecoraro 2020-03-30 18:04:27 PDT 
Comment on attachment 394994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394994&action=review

r=me

> Source/WebInspectorUI/UserInterface/Images/DocumentIcons.svg:-114
> -    <symbol id="doc-orig" stroke-width="1" viewBox="0 0 32 32">

Intended? Might want to call this out in the ChangeLog.
Comment 5 Jon Davis 2020-03-31 16:09:15 PDT 
Created attachment 395104 [details]
Patch
Comment 6 EWS 2020-03-31 17:55:35 PDT 
Committed r259329: <https://trac.webkit.org/changeset/259329>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395104 [details].
Comment 7 Radar WebKit Bug Importer 2020-03-31 17:56:13 PDT 
<rdar://problem/61133513>