Bug 209433

Summary: Web Inspector: REGRESSION(r257791): WebSocket icon is missing
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Jon Davis <jond>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
URL: https://devinrousso.com/dots/
Bug Depends on: 208458    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
WebSocket Icon in Dark Mode
none
WebSocket Icon in Light Mode
none
Patch none

Devin Rousso
Reported 2020-03-23 12:31:06 PDT
# STEPS TO REPRODUCE: 1. inspect <https://devinrousso.com/dots/> 2. go to the Sources Tab => the icon next to the `websocket` resource is missing :(
Attachments
Patch (5.92 KB, patch)
2020-03-30 17:58 PDT, Jon Davis 		no flags
DetailsFormatted DiffDiff
WebSocket Icon in Dark Mode (188.80 KB, image/png)
2020-03-30 17:59 PDT, Jon Davis 		no flags
Details
WebSocket Icon in Light Mode (179.21 KB, image/png)
2020-03-30 18:00 PDT, Jon Davis 		no flags
Details
Patch (5.97 KB, patch)
2020-03-31 16:09 PDT, Jon Davis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jon Davis
Comment 1 2020-03-30 17:58:21 PDT
Created attachment 394994 [details] Patch
Jon Davis
Comment 2 2020-03-30 17:59:51 PDT
Created attachment 394995 [details] WebSocket Icon in Dark Mode
Jon Davis
Comment 3 2020-03-30 18:00:05 PDT
Created attachment 394996 [details] WebSocket Icon in Light Mode
Joseph Pecoraro
Comment 4 2020-03-30 18:04:27 PDT
Comment on attachment 394994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394994&action=review r=me > Source/WebInspectorUI/UserInterface/Images/DocumentIcons.svg:-114 > - <symbol id="doc-orig" stroke-width="1" viewBox="0 0 32 32"> Intended? Might want to call this out in the ChangeLog.
Jon Davis
Comment 5 2020-03-31 16:09:15 PDT
Created attachment 395104 [details] Patch
EWS
Comment 6 2020-03-31 17:55:35 PDT
Committed r259329: <https://trac.webkit.org/changeset/259329> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395104 [details].
Radar WebKit Bug Importer
Comment 7 2020-03-31 17:56:13 PDT
<rdar://problem/61133513>
Note You need to log in before you can comment on or make changes to this bug.