| Summary: | [Web Animations] Refactor cancelDeclarativeAnimationsForElement and willDestroyRendererForElement on AnimationTimeline | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2020-03-23 06:44:16 PDT
Created attachment 394259 [details]
Patch
Comment on attachment 394259 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394259&action=review > Source/WebCore/animation/WebAnimation.h:96 > + virtual void cancel(Silently = Silently::No); Maybe Silently could be renamed to something more descriptive? enum class CancelType { CompletePromises, DontCompletePromises } or whatever the appropriate terminology is? (In reply to Antti Koivisto from comment #2) > Comment on attachment 394259 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394259&action=review > > > Source/WebCore/animation/WebAnimation.h:96 > > + virtual void cancel(Silently = Silently::No); > > Maybe Silently could be renamed to something more descriptive? > > enum class CancelType { CompletePromises, DontCompletePromises } > > or whatever the appropriate terminology is? After discussing directly with Antti, we figured that because this did not involve just promise rejection, but dispatch of the "cancel" event and timeline notification, that the "Silently" term was not so bad after all and would keep it as-is. Committed r258842: <https://trac.webkit.org/changeset/258842> |