Bug 209346

Summary: Web Inspector: REGRESSION(r257835): close and undock buttons are shown in remote inspector
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on: 208555    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2020-03-20 10:19:58 PDT
# STEPS TO REPRODUCE: 1. connect an external device or open an iOS simulator 2. inspect anything
Attachments
Patch (12.72 KB, patch)
2020-03-20 10:20 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-03-20 10:20:32 PDT
Created attachment 394097 [details] Patch
Blaze Burg
Comment 2 2020-03-20 12:03:50 PDT
Comment on attachment 394097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394097&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Main.js:900 > + WI.tabBar.resetCachedWidths(); How does the tabBar invalidate cached widths when the inspector window / view is resized? Surprised this is only called in one place. > Source/WebInspectorUI/UserInterface/Base/Main.js:2359 > + let closeHidden = WI._closeTabBarButton?.hidden; o_O I guess it's OK!
EWS
Comment 3 2020-03-20 12:22:09 PDT
Committed r258778: <https://trac.webkit.org/changeset/258778> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394097 [details].
Radar WebKit Bug Importer
Comment 4 2020-03-20 12:23:10 PDT
<rdar://problem/60698896>
Devin Rousso
Comment 5 2020-03-20 12:27:30 PDT
Comment on attachment 394097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394097&action=review >> Source/WebInspectorUI/UserInterface/Base/Main.js:900 >> + WI.tabBar.resetCachedWidths(); > > How does the tabBar invalidate cached widths when the inspector window / view is resized? Surprised this is only called in one place. When we're docked, the size of each `WI.TabBarItem` should never change, as we don't expand to fill available space. When undocked, however, `WI.TabBarItem` do expand to fill as much available space as possible. Along these lines, we have logic inside `WI.TabBar.prototype.layout` that handles this exact scenario :) <https://trac.webkit.org/browser/webkit/trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js?rev=258623#L469>
Note You need to log in before you can comment on or make changes to this bug.