Bug 209343

Summary: Fix JSCOnly build without unified sources
Product: WebKit Reporter: Justin Michaud <justin>
Component: JavaScriptCoreAssignee: Justin Michaud <justin_michaud>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Justin Michaud 2020-03-20 09:22:11 PDT 
I managed to get clangd to work for code completion using the following command:

./Tools/Scripts/build-webkit --jsc-only --cmakeargs="-DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DENABLE_UNIFIED_BUILDS=OFF" && compdb -p WebKitBuild/Release/ list > compile_commands.json

This patch fixes the build for non-unified sources, and adds some extra clangd files to .gitignore.
Comment 1 Justin Michaud 2020-03-20 09:28:27 PDT 
Created attachment 394092 [details]
Patch
Comment 2 Keith Miller 2020-03-20 10:22:32 PDT 
Comment on attachment 394092 [details]
Patch

r=me
Comment 3 EWS 2020-03-20 11:39:41 PDT 
Committed r258774: <https://trac.webkit.org/changeset/258774>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394092 [details].
Comment 4 Radar WebKit Bug Importer 2020-03-20 11:40:12 PDT 
<rdar://problem/60696207>