| Summary: | [iOS] Articles on NYTimes.com get truncated when switching between MobileSafari and another app | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ggaren, sgill26, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=211003 https://bugs.webkit.org/show_bug.cgi?id=258597 |
||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2020-03-19 17:00:30 PDT
Created attachment 394050 [details]
Patch
Comment on attachment 394050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394050&action=review > Source/WebCore/page/Page.h:731 > + bool shouldFireResizeEvents() const { return m_shouldFireResizeEvents; } > + void setShouldFireResizeEvents(bool shouldFireResizeEvents) { m_shouldFireResizeEvents = shouldFireResizeEvents; } I feel like introducing this as just a boolean setter (instead of a counted thing or a token or etc.) is just asking for trouble later when someone else wants to use it. But fine for now. Created attachment 394054 [details]
Patch
Comment on attachment 394054 [details]
Patch
Should we quirk this to nytimes? Seems like a hacky change to have in general.
(In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 394054 [details] > Patch > > Should we quirk this to nytimes? Seems like a hacky change to have in > general. Discussed this with Simon, Geoff and Tim offline. We think it is OK to try this as a general approach for now and reconsider if we find breakage. Those resizes in the background for snapshot are probably not something Web developers know about or even want/need to deal with. Committed r258767: <https://trac.webkit.org/changeset/258767> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394054 [details]. |