Bug 209278

Summary:

[GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, ews-watchlist, jbedard, pnormand

Priority:

Keywords:

Gtk, Regression

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	pnormand: review-
Patch	pnormand: review+

Description Carlos Garcia Campos 2020-03-19 06:31:37 PDT

This happens when using an external jhbuild as I do.

Comment 1 Carlos Garcia Campos 2020-03-19 06:33:39 PDT

Created attachment 393972 [details]
Patch

Comment 2 Philippe Normand 2020-03-19 06:50:06 PDT

Comment on attachment 393972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393972&action=review

> Tools/ChangeLog:9
> +        This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
> +        means flatpak.

What's failing exactly?

> Tools/Scripts/webkitdirs.pm:2176
> +    if (defined $ENV{'WEBKIT_JHBUILD'}) {

The env var value should be checked.

Comment 3 Carlos Garcia Campos 2020-03-19 06:58:59 PDT

Created attachment 393973 [details]
Patch

Comment 4 Carlos Garcia Campos 2020-03-19 07:03:57 PDT

Committed r258695: <https://trac.webkit.org/changeset/258695>