Bug 209260

Summary: Add SPI to move localStorage to a different domain
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2020-03-18 17:25:51 PDT
Add SPI to move localStorage to a different domain
Attachments
Patch (21.06 KB, patch)
2020-03-18 17:27 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (20.72 KB, patch)
2020-05-01 14:19 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (20.90 KB, patch)
2020-05-01 15:17 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-03-18 17:27:11 PDT
Created attachment 393924 [details] Patch
Alex Christensen
Comment 2 2020-03-18 17:27:14 PDT
<rdar://problem/60285683>
Alex Christensen
Comment 3 2020-03-23 11:40:53 PDT
https://trac.webkit.org/changeset/258862/webkit
Alex Christensen
Comment 4 2020-03-24 10:37:55 PDT
Reverted in https://trac.webkit.org/changeset/258914/webkit
Alex Christensen
Comment 5 2020-05-01 14:19:36 PDT
Created attachment 398238 [details] Patch
Alex Christensen
Comment 6 2020-05-01 14:23:23 PDT
Comment on attachment 398238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398238&action=review Turns out this is better than alternatives. > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:83 > +- (void)_renameOrigin:(NSURL *)oldName to:(NSURL *)newName forDataOfTypes:(NSSet<NSString *> *)dataTypes completionHandler:(void (^)(void))completionHandler; I changed these from NSStrings to NSURLs and _renameDomain to _renameOrigin > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:2415 > + networkProcess->addSession(*this); I also add the session if it hasn't been added yet so the use case works.
Alex Christensen
Comment 7 2020-05-01 15:17:54 PDT
Created attachment 398247 [details] Patch
EWS
Comment 8 2020-05-01 16:38:28 PDT
Committed r261038: <https://trac.webkit.org/changeset/261038> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398247 [details].
Note You need to log in before you can comment on or make changes to this bug.