Bug 209249

Summary: AX: VoiceOver and Safari: can't press the play button
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
darin: review+
patch none

Description chris fleizach 2020-03-18 14:39:47 PDT 
There are many web pages which has play buttton to let visitors to is ten sound
in IOS `13.4 betas, VO users can not pres play iron by double tap.
we need to double tap and hold instead
greate this could have a negative impact in usability.



https://www.applevis.com/blog/garageband-part-3-drummers-and-loops an example of such a page:

<rdar://problem/60174024>
Comment 1 chris fleizach 2020-03-18 17:41:14 PDT 
Created attachment 393925 [details]
patch
Comment 2 Darin Adler 2020-03-18 18:28:59 PDT 
Comment on attachment 393925 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393925&action=review

> Source/WebCore/ChangeLog:11
> +        If a node is in a shadowRoot, going up the node parent tree will stop and not check the entire tree for touch event listeners, 
> +        and a touch event won't be dispatched. If we use the accessibility hierarchy we'll be able to cross the shadow root boundary.

We don’t have to switch to the accessibility hierarchy just to deal with shadow. Could just call parentInComposedTree instead of parentNode.
Comment 3 chris fleizach 2020-03-18 18:45:24 PDT 
Comment on attachment 393925 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393925&action=review

>> Source/WebCore/ChangeLog:11
>> +        and a touch event won't be dispatched. If we use the accessibility hierarchy we'll be able to cross the shadow root boundary.
> 
> We don’t have to switch to the accessibility hierarchy just to deal with shadow. Could just call parentInComposedTree instead of parentNode.

ok will give that a try
Comment 4 chris fleizach 2020-03-18 20:23:35 PDT 
Created attachment 393941 [details]
patch
Comment 5 Darin Adler 2020-03-18 20:24:31 PDT 
Comment on attachment 393941 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393941&action=review

r=me if this works

> Source/WebCore/ChangeLog:11
> +        and a touch event won't be dispatched. If we use the accessibility hierarchy we'll be able to cross the shadow root boundary.

Should fix the comment.
Comment 6 chris fleizach 2020-03-18 23:28:31 PDT 
Created attachment 393952 [details]
patch
Comment 7 EWS 2020-03-19 10:45:43 PDT 
Committed r258711: <https://trac.webkit.org/changeset/258711>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 393952 [details].