Bug 209238

Summary: REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, jbedard, pnormand, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=205658
Attachments:
Description Flags
Patch jbedard: review+

Description Ryan Haddad 2020-03-18 09:29:11 PDT 
The changes to test262-runner in https://trac.webkit.org/changeset/258626 have broken the Apple Catalina test262 bots:

Undefined subroutine &Test262::Runner::setConfiguration called at /Volumes/Data/slave/catalina-debug-tests-test262/build/Tools/Scripts/test262/Runner.pm line 632.
Compilation failed in require at ./Tools/Scripts/test262-runner line 65.
BEGIN failed--compilation aborted at ./Tools/Scripts/test262-runner line 65.

https://build.webkit.org/builders/Apple-Catalina-Debug-Test262-Tests/builds/2153
Comment 1 Philippe Normand 2020-03-18 09:41:06 PDT 
Thanks for the report Ryan,

For the time being I can prepare a partial-rollout of the r258626.
Comment 2 Philippe Normand 2020-03-18 09:47:34 PDT 
Actually I may have a patch!
Comment 3 Philippe Normand 2020-03-18 09:48:39 PDT 
Created attachment 393871 [details]
Patch
Comment 4 Ryan Haddad 2020-03-18 09:56:14 PDT 
I manually applied this patch on one of the affected bots and it does indeed resolve the issue.
Comment 5 Philippe Normand 2020-03-18 10:09:51 PDT 
Committed r258644: <https://trac.webkit.org/changeset/258644>
Comment 6 Radar WebKit Bug Importer 2020-03-18 10:10:15 PDT 
<rdar://problem/60588867>