Bug 209221

Summary:

REGRESSION(r258626): webkit-dirs warning

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Tools / Tests

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, clopez, ews-watchlist, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=205658

Attachments:

Description	Flags
Patch	aperez: review+, aperez: commit-queue-

Description Philippe Normand 2020-03-18 03:03:31 PDT

$ env CC=clang CXX=clang++ build-webkit --gtk
Building flatpak based environment
Use of uninitialized value in numeric eq (==) at /app/webkit/Tools/Scripts/webkitdirs.pm line 2429.

Comment 1 Philippe Normand 2020-03-18 03:11:31 PDT

Created attachment 393831 [details]
Patch

Comment 2 Adrian Perez 2020-03-18 14:26:31 PDT

Comment on attachment 393831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393831&action=review

> Tools/ChangeLog:9
> +        (buildCMakeProjectOrExit): Fix Perl Warning. ð

There's an odd glyph at the end of the line; please remove
it before landing :-)

Comment 3 Philippe Normand 2020-03-18 15:17:46 PDT

It's an emoji. Bugzilla is that ancient, it doesn't know how to deal with those.

Comment 4 Adrian Perez 2020-03-18 16:49:35 PDT

(In reply to Philippe Normand from comment #3)
> It's an emoji. Bugzilla is that ancient, it doesn't know how to deal with
> those.

Heh. All is well, then 😉️

Comment 5 Philippe Normand 2020-03-19 02:50:34 PDT

Committed r258689: <https://trac.webkit.org/changeset/258689>

Comment 6 Radar WebKit Bug Importer 2020-03-19 02:51:13 PDT

<rdar://problem/60626558>