Bug 209200

Summary:

Web Inspector: the width of `WI.TabBarItem` can change if the detached window is resized

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=204627

Bug Depends on:

208603

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Devin Rousso 2020-03-17 15:20:08 PDT

From my comment <https://webkit.org/b/204627#c56>:
> We shouldn't need to worry about the value stored in `[WI.TabBar.CachedWidthSymbol]` changing anymore (meaning we don't need to reset it), as we no longer hide icons, meaning that the width of every `WI.TabBarItem` should be constant.

This isn't completely accurate, as we don't shrink `WI.TabBarItem` to their minimum width when detached.

Comment 1 Devin Rousso 2020-03-17 15:39:58 PDT

Created attachment 393797 [details]
Patch

Comment 2 WebKit Commit Bot 2020-03-17 21:30:27 PDT

Comment on attachment 393797 [details]
Patch

Clearing flags on attachment: 393797

Committed r258623: <https://trac.webkit.org/changeset/258623>

Comment 3 WebKit Commit Bot 2020-03-17 21:30:28 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2020-03-17 21:31:15 PDT

<rdar://problem/60569940>