Bug 209167

Summary: REGRESSION (r258334): WebPasteboardProxy::setPasteboardBufferForType should allow zero-size buffers
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ggaren, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-03-16 20:46:04 PDT
WebPasteboardProxy::setPasteboardBufferForType should allow zero-size buffers. <rdar://problem/60516302>
Attachments
Patch v1 (1.77 KB, patch)
2020-03-16 20:47 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-03-16 20:47:33 PDT
Created attachment 393723 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2020-03-16 20:50:22 PDT
As noted in the radar, I was unable to create a test for this. Changing Tools/TestWebKitAPI/Tests/WebKit/execCopy.html to contain only a single non-breaking space does not make the `size` parameter go to zero when running this test: $ ./Tools/Scripts/run-api-tests --release --no-build TestWebKitAPI.WebKit.PasteboardNotifications Changing execCopy.html to contain no copyable content makes the test hang.
Geoffrey Garen
Comment 3 2020-03-17 10:07:27 PDT
Comment on attachment 393723 [details] Patch v1 r=me
WebKit Commit Bot
Comment 4 2020-03-17 11:34:03 PDT
Comment on attachment 393723 [details] Patch v1 Clearing flags on attachment: 393723 Committed r258565: <https://trac.webkit.org/changeset/258565>
WebKit Commit Bot
Comment 5 2020-03-17 11:34:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.