Bug 209166

Summary: [Cocoa] Disable CF prefs direct mode
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: NEW ---    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, commit-queue, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Per Arne Vollan 2020-03-16 19:56:35 PDT
Revert <https://trac.webkit.org/changeset/258064> by disabling the CF prefs direct mode feature, since it caused performance regressions.
Comment 1 Per Arne Vollan 2020-03-16 20:04:18 PDT
rdar://problem/60517387
Comment 2 Per Arne Vollan 2020-03-16 20:33:34 PDT
Created attachment 393722 [details]
Patch
Comment 3 Brent Fulgham 2020-03-16 20:45:19 PDT
Comment on attachment 393722 [details]
Patch

Bummer! r=me
Comment 4 Per Arne Vollan 2020-03-16 20:58:19 PDT
Created attachment 393724 [details]
Patch
Comment 5 Per Arne Vollan 2020-03-16 20:58:48 PDT
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 393722 [details]
> Patch
> 
> Bummer! r=me

Yes! Thanks for reviewing :)
Comment 6 Per Arne Vollan 2020-03-16 21:36:55 PDT
Created attachment 393727 [details]
Patch
Comment 7 Per Arne Vollan 2020-03-16 22:03:53 PDT
Created attachment 393729 [details]
Patch
Comment 8 Per Arne Vollan 2020-03-16 22:34:03 PDT
Created attachment 393730 [details]
Patch
Comment 9 Per Arne Vollan 2020-03-17 07:14:29 PDT
Created attachment 393750 [details]
Patch
Comment 10 WebKit Commit Bot 2020-03-17 09:59:39 PDT
Comment on attachment 393750 [details]
Patch

Clearing flags on attachment: 393750

Committed r258557: <https://trac.webkit.org/changeset/258557>