Bug 209155

Summary: REGRESSION (r257472): Can't start old Safari with new WebKit (dyld: Symbol not found: _WKContextConfigurationSetShouldCaptureAudioInUIProcess)
Product: WebKit Reporter: Z <ziadrb>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208238
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Z 2020-03-16 16:13:19 PDT 
Not able to start Safari on Catalina (10.15.3)

$ svn info
Path: .
Working Copy Root Path: /Users/user/webkit
URL: https://svn.webkit.org/repository/webkit/trunk
Relative URL: ^/trunk
Repository Root: https://svn.webkit.org/repository/webkit
Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Revision: 258497
Node Kind: directory
Schedule: normal
Last Changed Author: commit-queue@webkit.org
Last Changed Rev: 258497
Last Changed Date: 2020-03-16 10:27:05 -0500 (Mon, 16 Mar 2020)

Configured as

$ Tools/Scripts/set-webkit-configuration --asan --release

Built as

$ Tools/Scripts/build-webkit

Run

$ Tools/Scripts/run-safari 
Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in /Users/user/webkit/WebKitBuild/Release.
dyld: Symbol not found: _WKContextConfigurationSetShouldCaptureAudioInUIProcess
  Referenced from: /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari
  Expected in: /Users/user/webkit/WebKitBuild/Release/WebKit.framework/Versions/A/WebKit
 in /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari
Comment 1 Darin Adler 2020-03-16 17:20:10 PDT 
Caused by <https://trac.webkit.org/changeset/257472>. Need to leave a stub behind to keep old Safari working.

We should fix this so people outside Apple can continue to work on WebKit.
Comment 2 youenn fablet 2020-03-17 01:22:34 PDT 
Created attachment 393735 [details]
Patch
Comment 3 Eric Carlson 2020-03-17 09:19:57 PDT 
Comment on attachment 393735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393735&action=review

> Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:75
> +// FIXME: https://bugs.webkit.org/show_bug.cgi?id=209155. Remove this function once no longer useful torun latest WebKit with older Safari.

s/torun/to run/
Comment 4 Darin Adler 2020-03-17 12:50:28 PDT 
Comment on attachment 393735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393735&action=review

> Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:76
> +WK_EXPORT void WKContextConfigurationSetShouldCaptureAudioInUIProcess(WKContextConfigurationRef configuration, bool allowed);

In past cases like this one we left the thing out of the header file and put it in the .cpp file with a comment like the one above. We should put it at the top of the .cpp file instead of here.
Comment 5 youenn fablet 2020-03-18 05:29:20 PDT 
Created attachment 393834 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2020-03-18 07:24:24 PDT 
Comment on attachment 393834 [details]
Patch for landing

Clearing flags on attachment: 393834

Committed r258629: <https://trac.webkit.org/changeset/258629>
Comment 7 WebKit Commit Bot 2020-03-18 07:24:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-03-18 07:25:15 PDT 
<rdar://problem/60583675>