| Summary: | Sync web-platform-tests/css/css-cascade from upstream | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||||
| Component: | CSS | Assignee: | Alexey Shvayka <ashvayka> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Enhancement | CC: | cdumez, commit-queue, koivisto, rniwa, simon.fraser, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alexey Shvayka
2020-03-16 15:27:21 PDT
Comment hidden (obsolete)
Created attachment 393693 [details]
Patch
Created attachment 393733 [details]
Patch
Add missing expected result.
Comment on attachment 393733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393733&action=review > LayoutTests/TestExpectations:1810 > +[ Debug ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html [ Pass Crash ] If it is crashing, let's skip it in Debug for now and let's file a bug. Created attachment 393736 [details]
Patch
Set reviewer, link crashing test to bug and skip it.
Comment on attachment 393736 [details] Patch Clearing flags on attachment: 393736 Committed r258543: <https://trac.webkit.org/changeset/258543> All reviewed patches have been landed. Closing bug. Committed r258544: <https://trac.webkit.org/changeset/258544> (In reply to Alexey Shvayka from comment #8) > Committed r258544: <https://trac.webkit.org/changeset/258544> This change adds iOS expectations for crashing test, which are slightly different: --- a/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt +++ b/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt @@ -345,6 +345,7 @@ PASS -webkit-mask-repeat PASS -webkit-mask-size PASS -webkit-mask-source-type PASS -webkit-nbsp-mode +PASS -webkit-overflow-scrolling PASS -webkit-print-color-adjust PASS -webkit-rtl-ordering PASS -webkit-ruby-position @@ -359,6 +360,7 @@ PASS -webkit-text-size-adjust PASS -webkit-text-stroke-color PASS -webkit-text-stroke-width PASS -webkit-text-zoom +PASS -webkit-touch-callout PASS -webkit-transform-style PASS -webkit-user-drag PASS -webkit-user-modify |