Bug 209127

Summary: Remove addHTTPOriginIfNeeded calls
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, ews-watchlist, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2020-03-15 11:34:34 PDT
Remove addHTTPOriginIfNeeded calls since they are get requests and navigations and the spec [1] indicates that the Origin header should not be written out, making these calls no-ops. [1] https://fetch.spec.whatwg.org/#append-a-request-origin-header
Attachments
Patch (4.33 KB, patch)
2020-03-15 11:35 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2020-03-29 06:10 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-03-15 11:35:55 PDT
Created attachment 393620 [details] Patch
WebKit Commit Bot
Comment 2 2020-03-16 01:11:31 PDT
Comment on attachment 393620 [details] Patch Clearing flags on attachment: 393620 Committed r258488: <https://trac.webkit.org/changeset/258488>
WebKit Commit Bot
Comment 3 2020-03-16 01:11:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-03-16 01:12:12 PDT
<rdar://problem/60486281>
Rob Buis
Comment 5 2020-03-29 06:10:35 PDT
Reopening to attach new patch.
Rob Buis
Comment 6 2020-03-29 06:10:38 PDT
Created attachment 394865 [details] Patch
Darin Adler
Comment 7 2020-03-29 09:21:06 PDT
Comment on attachment 394865 [details] Patch Looks fine. Next time I suggest using a new bug report. I don’t think reopening is a good way to handle follow up even though I see a lot of people doing it. I think reopening is a good way to handle trying again rolling out or trying again if the first try did not successfully fix the bug.
Rob Buis
Comment 8 2020-03-29 10:28:07 PDT
Point taken!
EWS
Comment 9 2020-03-29 10:34:22 PDT
Committed r259182: <https://trac.webkit.org/changeset/259182> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394865 [details].
Note You need to log in before you can comment on or make changes to this bug.