Bug 209117

Summary: Add missing checks needed for AppBound Quirk
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bfulgham, cdumez, commit-queue, ews-watchlist, japhet, katherine_cheney, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Brent Fulgham
Reported 2020-03-14 15:56:56 PDT
In Bug 208777 I made it possible to turn off InAppBrowserPrivacy quirks, but missed a few places. This patch corrects that oversight.
Attachments
Patch (8.48 KB, patch)
2020-03-14 16:10 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.69 KB, patch)
2020-03-14 16:30 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-03-14 15:58:03 PDT
<rdar://problem/60460097>
Brent Fulgham
Comment 2 2020-03-14 16:10:45 PDT
Created attachment 393595 [details] Patch
John Wilander
Comment 3 2020-03-14 16:18:37 PDT
Comment on attachment 393595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393595&action=review r=me with comments. > Source/WebKit/ChangeLog:8 > + Did you mean to put the same description here as in the WebCore change log? > Source/WebCore/loader/FrameLoaderClient.h:383 > + virtual bool needsInAppBrowserPrivacyQuirks() { return false; } Is there a reason for not making this const? > Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:292 > + bool needsInAppBrowserPrivacyQuirks() final; This too could be const.
Brent Fulgham
Comment 4 2020-03-14 16:22:52 PDT
Comment on attachment 393595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393595&action=review >> Source/WebKit/ChangeLog:8 >> + > > Did you mean to put the same description here as in the WebCore change log? Whoops! Yes. >> Source/WebCore/loader/FrameLoaderClient.h:383 >> + virtual bool needsInAppBrowserPrivacyQuirks() { return false; } > > Is there a reason for not making this const? Good catch.
Brent Fulgham
Comment 5 2020-03-14 16:30:29 PDT
Created attachment 393596 [details] Patch for landing
WebKit Commit Bot
Comment 6 2020-03-14 17:14:38 PDT
Comment on attachment 393596 [details] Patch for landing Clearing flags on attachment: 393596 Committed r258476: <https://trac.webkit.org/changeset/258476>
WebKit Commit Bot
Comment 7 2020-03-14 17:14:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.