| Summary: | Add missing checks needed for AppBound Quirk | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
| Component: | WebKit2 | Assignee: | Brent Fulgham <bfulgham> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aestes, bfulgham, cdumez, commit-queue, ews-watchlist, japhet, katherine_cheney, webkit-bug-importer, wilander | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Brent Fulgham
2020-03-14 15:56:56 PDT
Created attachment 393595 [details]
Patch
Comment on attachment 393595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393595&action=review r=me with comments. > Source/WebKit/ChangeLog:8 > + Did you mean to put the same description here as in the WebCore change log? > Source/WebCore/loader/FrameLoaderClient.h:383 > + virtual bool needsInAppBrowserPrivacyQuirks() { return false; } Is there a reason for not making this const? > Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:292 > + bool needsInAppBrowserPrivacyQuirks() final; This too could be const. Comment on attachment 393595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393595&action=review >> Source/WebKit/ChangeLog:8 >> + > > Did you mean to put the same description here as in the WebCore change log? Whoops! Yes. >> Source/WebCore/loader/FrameLoaderClient.h:383 >> + virtual bool needsInAppBrowserPrivacyQuirks() { return false; } > > Is there a reason for not making this const? Good catch. Created attachment 393596 [details]
Patch for landing
Comment on attachment 393596 [details] Patch for landing Clearing flags on attachment: 393596 Committed r258476: <https://trac.webkit.org/changeset/258476> All reviewed patches have been landed. Closing bug. |