| Summary: | Share HitTestResult::addNodeToListBasedTestResult() impl for LayoutRect and FloatRect overloads | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
| Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | beidson, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 209110 | ||||||
| Attachments: |
|
||||||
|
Description
Daniel Bates
2020-03-14 10:31:39 PDT
Created attachment 393585 [details]
Patch
Comment on attachment 393585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393585&action=review > Source/WebCore/rendering/HitTestResult.h:152 > + template<typename RectType> HitTestProgress addNodeToListBasedTestResultCommon(Node*, const HitTestRequest&, const HitTestLocation&, const RectType&); Could also make node const....I'll try and maybe fold it into this patch. Comment on attachment 393585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393585&action=review >> Source/WebCore/rendering/HitTestResult.h:152 >> + template<typename RectType> HitTestProgress addNodeToListBasedTestResultCommon(Node*, const HitTestRequest&, const HitTestLocation&, const RectType&); > > Could also make node const....I'll try and maybe fold it into this patch. Actually, I am not going to do this in this patch as I would need to fix up more things.... Thanks for the review! Comment on attachment 393585 [details] Patch Clearing flags on attachment: 393585 Committed r258468: <https://trac.webkit.org/changeset/258468> All reviewed patches have been landed. Closing bug. |