Bug 209100

Summary:

[Tree building] Reset the fragmented flow status before calling child.willBeRemovedFromTree.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2020-03-13 20:44:21 PDT

willBeRemovedFromTree assumes all the cleanup has already happened.

Comment 1 zalan 2020-03-13 20:44:39 PDT

<rdar://problem/60434672>

Comment 2 zalan 2020-03-13 20:51:17 PDT

Created attachment 393571 [details]
Patch

Comment 3 Simon Fraser (smfr) 2020-03-13 20:54:39 PDT

Comment on attachment 393571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393571&action=review

> Source/WebCore/ChangeLog:3
> +        [Tree building] Reset the fragmented flow status before signal will-be-removed.

Maybe "before calling child.willBeRemovedFromTree()"

> Source/WebCore/ChangeLog:9
> +        ::willBeRemoved() assumes all the cleanup has happened and it's the final step before calling d'tor.

It this referring to the child.willBeRemovedFromTree()?

Comment 4 zalan 2020-03-14 04:31:31 PDT

Created attachment 393582 [details]
Patch

Comment 5 zalan 2020-03-14 04:32:22 PDT

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 393571 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393571&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [Tree building] Reset the fragmented flow status before signal will-be-removed.
> 
> Maybe "before calling child.willBeRemovedFromTree()"
> 
> > Source/WebCore/ChangeLog:9
> > +        ::willBeRemoved() assumes all the cleanup has happened and it's the final step before calling d'tor.
> 
> It this referring to the child.willBeRemovedFromTree()?
Correct. I confused it with willBeDestroyed.

Comment 6 WebKit Commit Bot 2020-03-14 05:57:40 PDT

Comment on attachment 393582 [details]
Patch

Clearing flags on attachment: 393582

Committed r258466: <https://trac.webkit.org/changeset/258466>

Comment 7 WebKit Commit Bot 2020-03-14 05:57:42 PDT

All reviewed patches have been landed.  Closing bug.