| Summary: | [GPU Process] GraphicsContextStateChange::apply() should process ShadowsIgnoreTransformsChange before processing ShadowChange | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||
| Component: | Canvas | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, darin, dino, mmaxfield, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Said Abou-Hallawa
2020-03-13 11:53:28 PDT
Created attachment 393512 [details]
Patch
Created attachment 393514 [details]
test case
Repro steps: 1. Launch mini-browser 2. Enable "Settings/Internal Features/Render Canvas in GPU Process" or "Settings/Enable Display List Drawing". 3. Open the attached test case Result: the test case shows a 100x100 green rectangle Expected: the test case shows a 100x100 green rectangle with its shadow 100x100 red rectangle This patch fixes the following test cases when running "run-webkit-tests --internal-feature RenderCanvasInGPUProcessEnabled" fast/canvas/canvas-image-shadow.html fast/canvas/canvas-scale-drawImage-shadow.html fast/canvas/canvas-scale-fillPath-shadow.html fast/canvas/canvas-scale-fillRect-shadow.html fast/canvas/canvas-scale-shadowBlur.html fast/canvas/canvas-transforms-fillRect-shadow.html fast/canvas/fillText-shadow.html (In reply to Said Abou-Hallawa from comment #4) > This patch fixes the following test cases when running "run-webkit-tests > --internal-feature RenderCanvasInGPUProcessEnabled" > > fast/canvas/canvas-image-shadow.html > fast/canvas/canvas-scale-drawImage-shadow.html > fast/canvas/canvas-scale-fillPath-shadow.html > fast/canvas/canvas-scale-fillRect-shadow.html > fast/canvas/canvas-scale-shadowBlur.html > fast/canvas/canvas-transforms-fillRect-shadow.html > fast/canvas/fillText-shadow.html Change log should mention this. Created attachment 393540 [details]
Patch
Comment on attachment 393540 [details] Patch Clearing flags on attachment: 393540 Committed r258454: <https://trac.webkit.org/changeset/258454> All reviewed patches have been landed. Closing bug. |