| Summary: | [ews] run FindModifiedChangeLogs early in the build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2020-03-13 10:24:32 PDT
Created attachment 393498 [details]
Patch
Comment on attachment 393498 [details]
Patch
Does it make sense to do this before compiling and testing? Or should we do it after compiling and testing, but before updating?
(In reply to Jonathan Bedard from comment #2) > Does it make sense to do this before compiling and testing? Or should we do it after compiling and testing, but before updating? Probably doesn't make much difference. Might be slightly better before compiling, just after applying the patch (since git status would be based on only patch contents). Comment on attachment 393498 [details] Patch Clearing flags on attachment: 393498 Committed r258420: <https://trac.webkit.org/changeset/258420> All reviewed patches have been landed. Closing bug. This change should reduce the chances of issues like https://bugs.webkit.org/show_bug.cgi?id=209125 (where landing failed, because during the time repo was updated to ToT and patch was attempted to be landed, there was another commit which modified similar files). |