| Summary: | [iOS WK2] Some pointerevents tests time out | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | UI Events | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | graouts, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2020-03-12 16:21:21 PDT
Created attachment 393427 [details]
Patch
Comment on attachment 393427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393427&action=review > LayoutTests/pointerevents/utils.js:146 > setTimeout(resolve, durationInSeconds * 1000) Not for this patch, but it looks like we should fix this to actually listen for the zooming UIScriptController callbacks to know when the zooming animation is done instead of having a hard-coded timeout. > LayoutTests/pointerevents/utils.js:231 > + console.log(script); Was this console.log intended? Comment on attachment 393427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393427&action=review > LayoutTests/pointerevents/utils.js:230 > + let script = `uiController.${command}(${args}, () => uiController.uiScriptComplete());`; You could use `const` here instead of `let`. |