Bug 209025

Summary: REGRESSION (r257739): [ iOS ] fast/events/autoscroll-in-iframe.html is still flaky failing
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: andresg_22, bfulgham, cfleizach, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208520

Description Jacob Uphoff 2020-03-12 16:12:46 PDT 
fast/events/autoscroll-in-iframe.html

This test has been flaky failing for all of iOS since around r257740 

Started off failing more consistently but now is failing more flakily.

History:

https://results.webkit.org/?suite=layout-tests&test=fast%2Fevents%2Fautoscroll-in-iframe.html&platform=ios

Diff:

--- /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-results/fast/events/autoscroll-in-iframe-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-results/fast/events/autoscroll-in-iframe-actual.txt
@@ -1,3 +1,4 @@
 
+FAILED: Clicking in the iframe scrolled the page (window.scrollTops is 0)
 PASSED: selecting in the iframe did not scroll the page.
Comment 1 Radar WebKit Bug Importer 2020-03-12 16:13:10 PDT 
<rdar://problem/60392238>
Comment 2 Jacob Uphoff 2020-03-12 16:22:15 PDT 
Set expectations here: https://trac.webkit.org/changeset/258370/webkit
Comment 3 Alexey Proskuryakov 2020-03-13 09:18:20 PDT 
There was an attempt to fix these in r208520, which improved the situation. But it's still failing around half of the time.
Comment 4 Alexey Proskuryakov 2020-03-13 09:19:19 PDT 
I meant to say, in bug 208520.
Comment 5 chris fleizach 2020-03-13 10:49:35 PDT 
(In reply to Alexey Proskuryakov from comment #4)
> I meant to say, in bug 208520.

if we really think  r257740  is the cause of this, it's likely the reason is that accessibility is being enabled on iOS unexpectedly. that is what I'll look for
Comment 6 chris fleizach 2020-03-13 11:05:48 PDT 
(In reply to chris fleizach from comment #5)
> (In reply to Alexey Proskuryakov from comment #4)
> > I meant to say, in bug 208520.
> 
> if we really think  r257740  is the cause of this, it's likely the reason is
> that accessibility is being enabled on iOS unexpectedly. that is what I'll
> look for

Must have been

https://bugs.webkit.org/show_bug.cgi?id=208434
Comment 7 chris fleizach 2020-03-13 11:24:28 PDT 
So there was clearly something enabling accessibility previously. That was clearly fixed. Looking through original patch, this is the only thing that does something different.

-    return textMarkerRangeFromVisiblePositions(self.axBackingObject->axObjectCache(), startPosition, endPosition);
+    auto* backingObject = self.updateObjectBackingStore;
+    if (!backingObject)
+        return nil;
+
+    return textMarkerRangeFromVisiblePositions(backingObject->axObjectCache(), startPosition, endPosition);

by calling self.updateObjectBackingStore
Comment 8 Andres Gonzalez 2020-03-13 12:40:10 PDT 
(In reply to chris fleizach from comment #7)
> So there was clearly something enabling accessibility previously. That was
> clearly fixed. Looking through original patch, this is the only thing that
> does something different.
> 
> -    return
> textMarkerRangeFromVisiblePositions(self.axBackingObject->axObjectCache(),
> startPosition, endPosition);
> +    auto* backingObject = self.updateObjectBackingStore;
> +    if (!backingObject)
> +        return nil;
> +
> +    return
> textMarkerRangeFromVisiblePositions(backingObject->axObjectCache(),
> startPosition, endPosition);
> 
> by calling self.updateObjectBackingStore

that was fix in patch for bug:

https://bugs.webkit.org/show_bug.cgi?id=208648

so that cannot be the cause if this is still failing.