Bug 209015

Summary: [ANGLE] Source/ThirdParty/ANGLE/src/libANGLE/Display.h:221:73: warning: implicitly-declared ‘egl::AttributeMap& egl::AttributeMap::operator=(const egl::AttributeMap&)’ is deprecated [-Wdeprecated-copy]
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: ANGLEAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, darin, dino, ews-watchlist, graouts, gyuyoung.kim, jdarpinian, justin_fan, kbr, kondapallykalyan, mcatanzaro, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Michael Catanzaro 2020-03-12 13:20:50 PDT
[398/1919] Building CXX object Source/...r/src/libANGLE/FrameCapture_mock.cpp.o
In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/entry_points_utils.h:17,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture.h:16,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture_mock.cpp:10:
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Display.h: In member function ‘void egl::Display::setAttributes(const egl::AttributeMap&)’:
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Display.h:221:73: warning: implicitly-declared ‘egl::AttributeMap& egl::AttributeMap::operator=(const egl::AttributeMap&)’ is deprecated [-Wdeprecated-copy]
  221 |     void setAttributes(const AttributeMap &attribMap) { mAttributeMap = attribMap; }
      |                                                                         ^~~~~~~~~
In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Debug.h:15,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/State.h:18,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Context.h:52,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture.h:14,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture_mock.cpp:10:
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/AttributeMap.h:24:5: note: because ‘egl::AttributeMap’ has user-provided ‘egl::AttributeMap::AttributeMap(const egl::AttributeMap&)’
   24 |     AttributeMap(const AttributeMap &other);
      |     ^~~~~~~~~~~~
Comment 1 Michael Catanzaro 2020-03-12 13:47:05 PDT
Created attachment 393410 [details]
Patch
Comment 2 EWS Watchlist 2020-03-12 13:47:54 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 WebKit Commit Bot 2020-03-15 18:41:19 PDT
Comment on attachment 393410 [details]
Patch

Clearing flags on attachment: 393410

Committed r258483: <https://trac.webkit.org/changeset/258483>
Comment 4 WebKit Commit Bot 2020-03-15 18:41:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-15 18:42:18 PDT
<rdar://problem/60478335>
Comment 6 Konstantin Tokarev 2020-03-15 19:00:53 PDT
Comment on attachment 393410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393410&action=review

> Source/ThirdParty/ANGLE/ChangeLog:10
> +        using.

That's fine, but I guess it would be a good idea to CC ANGLE folks
Comment 7 Kenneth Russell 2020-03-16 19:17:57 PDT
Thanks for the CC. Filed this against the ANGLE project as https://bugs.chromium.org/p/angleproject/issues/detail?id=4486 .