Bug 209010

Summary: Cache the ScrollView platformWidget to avoid [WebAccessibilityObjectWrapper scrollViewParent] hitting the main thread too often.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andres Gonzalez 2020-03-12 12:38:52 PDT 
Cache the ScrollView platformWidget to avoid [WebAccessibilityObjectWrapper scrollViewParent] hitting the main thread too often.
Comment 1 Andres Gonzalez 2020-03-12 12:56:52 PDT 
Created attachment 393402 [details]
Patch
Comment 2 chris fleizach 2020-03-12 13:10:30 PDT 
Comment on attachment 393402 [details]
Patch

this looks like it will work. holding onto a NSView off the main thread shouldn't be problematic in and of itself. however, if AppKit makes ax calls on that object outside of WebKit it might require a change in AppKit
Comment 3 WebKit Commit Bot 2020-03-12 14:12:18 PDT 
Comment on attachment 393402 [details]
Patch

Clearing flags on attachment: 393402

Committed r258356: <https://trac.webkit.org/changeset/258356>
Comment 4 WebKit Commit Bot 2020-03-12 14:12:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-12 14:13:14 PDT 
<rdar://problem/60386610>