| Summary: | Resource load statistics data summary should return all third party data | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||||
| Component: | WebKit Misc. | Assignee: | Kate Cheney <katherine_cheney> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, webkit-bug-importer, wilander | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Kate Cheney
2020-03-12 09:19:08 PDT
Created attachment 393383 [details]
Patch
Comment on attachment 393383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393383&action=review r=me. Please address my comment on the cookie blocking mode. > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:844 > + || sortedStatistics.bindText(1, "%") I think this should be made conditional on the configured WebCore::ThirdPartyCookieBlockingMode. If == WebCore::ThirdPartyCookieBlockingMode::All, send back all third party data, otherwise keep the old behavior. You already have a thirdPartyCookieBlockingMode() getter in the ResourceLoadStatisticsStore base class. Then your API tests might have to enable WebCore::ThirdPartyCookieBlockingMode::All if they aren't already running under that configuration. > Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:986 > + // Set two third parties to be prevalent, leave evil1.com as non-prevalent to ensure Personally, I'd prefer not to call prevalent domains "evil" since there's nothing inherently evil about them. But I know it's existing code. Created attachment 393405 [details]
Patch
(In reply to katherine_cheney from comment #4) > Created attachment 393405 [details] > Patch Thanks John! Made these changes. Waiting on EWS before cq+ Comment on attachment 393405 [details] Patch Clearing flags on attachment: 393405 Committed r258357: <https://trac.webkit.org/changeset/258357> All reviewed patches have been landed. Closing bug. |