| Summary: | [GPUP] Add special handling of MediaTime within message generator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
| Component: | Tools / Tests | Assignee: | Don Olmstead <don.olmstead> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 206697 | ||||||
| Attachments: |
|
||||||
Created attachment 393313 [details]
Patch
Comment on attachment 393313 [details] Patch Clearing flags on attachment: 393313 Committed r258305: <https://trac.webkit.org/changeset/258305> All reviewed patches have been landed. Closing bug. |
GPU Process added MediaTime to messages.in files. The messages.py script wasn't updated for special handling of this. Pretty sure the only reason this works is because of a .cpp file being included in a unified build. For non-unified builds the following happens In file included from ../../Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:35: WebKit/DerivedSources\MediaPlayerPrivateRemoteMessages.h:546:75: error: unknown type name 'MediaTime' typedef std::tuple<const WebKit::TrackPrivateRemoteIdentifier&, const MediaTime&, const MediaTime&, const IPC::DataReference&> Arguments;