| Summary: | Make flatpack import for run-webkit-tests only happen on linux systems | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Lewis <jlewis3> | ||||||
| Component: | Tools / Tests | Assignee: | Matt Lewis <jlewis3> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | clopez, commit-queue, jbedard, mcatanzaro, pnormand, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Matt Lewis
2020-03-11 16:27:31 PDT
Created attachment 393308 [details]
Patch
Comment on attachment 393308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393308&action=review This looks correct to be, but I'd like the folks more familiar with how we actually use flatpak. Another alternative approach would be to conditionalize on if flatpak can be found in the provided directory. > Tools/Scripts/run-webkit-tests:16 > +# * Neither the Google name nor the names of its No reason to make this change Comment on attachment 393308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393308&action=review > Tools/Scripts/run-webkit-tests:39 > +if sys.platform.startswith('Linux'): lower-case linux Created attachment 393386 [details]
Patch
Comment on attachment 393386 [details] Patch Clearing flags on attachment: 393386 Committed r258347: <https://trac.webkit.org/changeset/258347> All reviewed patches have been landed. Closing bug. |