Bug 208953

Summary: [macOS] _AXSApplicationAccessibilityEnabled should not be called
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 208957    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Per Arne Vollan 2020-03-11 16:16:30 PDT 
This function should only be called on iOS, not on macOS.
Comment 1 Per Arne Vollan 2020-03-11 16:18:13 PDT 
Created attachment 393302 [details]
Patch
Comment 2 Brent Fulgham 2020-03-11 16:24:52 PDT 
Comment on attachment 393302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393302&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:459
> +    if (_AXSApplicationAccessibilityEnabled())

So we still want to pass the cfprefsd extension on macOS without checking this call?

> Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:213
> +#if PLATFORM(IOS_FAMILY)

Does this call work on MacCatalyst? Maybe this should exclude MacCatalyst builds?
Comment 3 Brent Fulgham 2020-03-11 16:25:16 PDT 
r=me, but please make sure the MacCatalyst bits are correct.
Comment 4 Per Arne Vollan 2020-03-11 16:28:16 PDT 
Committed r258294: <https://trac.webkit.org/changeset/258294/webkit>
Comment 5 Radar WebKit Bug Importer 2020-03-11 16:29:12 PDT 
<rdar://problem/60346791>
Comment 6 Per Arne Vollan 2020-03-11 16:37:37 PDT 
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 393302 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393302&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:459
> > +    if (_AXSApplicationAccessibilityEnabled())
> 
> So we still want to pass the cfprefsd extension on macOS without checking
> this call?
> 

I believe we want a similar functionality on macOS, but we cannot use _AXSApplicationAccessibilityEnabled() for this. I am looking into alternatives.

> > Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:213
> > +#if PLATFORM(IOS_FAMILY)
> 
> Does this call work on MacCatalyst? Maybe this should exclude MacCatalyst
> builds?

Yes, I believe this will work on MacCatalyst.

Thanks for reviewing!
Comment 7 WebKit Commit Bot 2020-03-11 16:52:01 PDT 
Re-opened since this is blocked by bug 208957
Comment 8 Per Arne Vollan 2020-03-12 12:44:22 PDT 
Created attachment 393397 [details]
Patch
Comment 9 Per Arne Vollan 2020-03-12 12:49:58 PDT 
Created attachment 393400 [details]
Patch
Comment 10 Brent Fulgham 2020-03-12 13:27:05 PDT 
Comment on attachment 393400 [details]
Patch

Hopefully this will get the bots happy. r=me
Comment 11 Per Arne Vollan 2020-03-12 13:50:55 PDT 
Comment on attachment 393400 [details]
Patch

Thanks for reviewing!
Comment 12 WebKit Commit Bot 2020-03-12 14:36:14 PDT 
Comment on attachment 393400 [details]
Patch

Clearing flags on attachment: 393400

Committed r258359: <https://trac.webkit.org/changeset/258359>
Comment 13 WebKit Commit Bot 2020-03-12 14:36:16 PDT 
All reviewed patches have been landed.  Closing bug.