Bug 208952

Summary:

[CMake] Warning when ccache is not installed

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

CMake

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, commit-queue, don.olmstead, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio

Priority:

Version:

WebKit Nightly Build

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Michael Catanzaro 2020-03-11 16:10:35 PDT

This warning is not useful:

CMake Warning at Source/cmake/WebKitCCache.cmake:25 (message):
  Enabling ccache: Couldn't find ccache program.  Not enabling it.
Call Stack (most recent call first):
  Source/cmake/WebKitCommon.cmake:51 (include)
  CMakeLists.txt:169 (include)

Comment 1 Michael Catanzaro 2020-03-11 16:11:56 PDT

Created attachment 393301 [details]
Patch

Comment 2 Daniel Bates 2020-03-13 23:38:06 PDT

Comment on attachment 393301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393301&action=review

> ChangeLog:10
> +        Change the warning when ccache is not installed to a status message. We shouldn't be

Same things as in bug 208970, comment 3, Again patch is OK as-is. NO CHANGE NEEDED.

[[
This is ok as-is. No change is needed. The optimal ChangeLog would move all the text in this line and later ABOVE the file name so as to be the description of the change because:

1. There is only one file changed in this patch so there's no need for per file comments.

2. Per file/function comments should be concise, no longer than a single paragraph. They are meant to provide more fine grain descriptions of the charges in the patch.
]]

Comment 3 Michael Catanzaro 2020-03-14 08:19:45 PDT

Thanks Daniel.

I see I'm getting rusty with ChangeLogs....

Comment 4 Michael Catanzaro 2020-03-14 08:20:42 PDT

Created attachment 393584 [details]
Patch for landing

Comment 5 WebKit Commit Bot 2020-03-14 09:10:30 PDT

Comment on attachment 393584 [details]
Patch for landing

Clearing flags on attachment: 393584

Committed r258467: <https://trac.webkit.org/changeset/258467>

Comment 6 WebKit Commit Bot 2020-03-14 09:10:32 PDT

All reviewed patches have been landed.  Closing bug.