| Summary: | Adopt AVSampleBufferVideoOutput | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, benjamin, cdumez, cmarcelo, commit-queue, eric.carlson, ews-watchlist, glenn, philipj, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jer Noble
2020-03-11 15:55:31 PDT
Created attachment 393298 [details]
Patch
Comment on attachment 393298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393298&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:772 > + m_videoOutput = adoptNS([PAL::allocAVSampleBufferVideoOutputInstance() init]); Nit: it might be worth adding an ASSERT here Created attachment 393303 [details]
Patch for landing
Comment on attachment 393303 [details] Patch for landing Clearing flags on attachment: 393303 Committed r258314: <https://trac.webkit.org/changeset/258314> All reviewed patches have been landed. Closing bug. |