| Summary: | Add API endpoint in EWS django app to provide patch status in json format | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, jbedard, kocsen_chung, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=209342 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 208938 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Aakash Jain
2020-03-11 12:51:23 PDT
Created attachment 393279 [details]
Patch
Comment on attachment 393279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393279&action=review > Tools/ChangeLog:3 > + Add API endpoint in EWS django app to provide patch status in json format Good idea, curious if there is a specific use case you had in mind for this > Tools/BuildSlaveSupport/ews-app/ews/views/status.py:43 > + if build.result is None: I wonder if something like this would be more elegant: bubble['state'] = { None: 'started', Buildbot.SUCCESS: 'pass', Buildbot.WARNINGS: 'pass', ... }.get(build.result, 'error') Created attachment 393419 [details]
Patch
(In reply to Jonathan Bedard from comment #3) > Good idea, curious if there is a specific use case you had in mind for this For https://bugs.webkit.org/show_bug.cgi?id=208938 > I wonder if something like this would be more elegant: I simplified it further, simply used build.result for 'state'. Comment on attachment 393419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393419&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/status.py:67 > + response_data = {'status': self._build_statuses_for_patch(patch)} I think we should return the list directly instead of packaging it in a dictionary. Created attachment 393511 [details]
Patch for landing
(In reply to Jonathan Bedard from comment #6) > I think we should return the list directly instead of packaging it in a dictionary. Done in updated patch. Comment on attachment 393511 [details] Patch for landing Clearing flags on attachment: 393511 Committed r258415: <https://trac.webkit.org/changeset/258415> All reviewed patches have been landed. Closing bug. |