| Summary: | commit-queue should skip testing if patch already passed tests on mac-wk2 queue | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=208941 | ||||||||||
| Bug Depends on: | 208940, 209342 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Aakash Jain
2020-03-11 12:48:34 PDT
IIRC the old queue would re-test if substantial amount of time passed since the EWS run. We had a lot of discussion about stricter logic in the past (e.g. don't land until all EWSes were done), but no concrete changes planned. Created attachment 394113 [details]
Patch
Comment on attachment 394113 [details] Patch Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/1660 (In reply to Alexey Proskuryakov from comment #1) > IIRC the old queue would re-test if substantial amount of time passed since the EWS run. I don't see any logic regarding time limit for re-testing in old EWS code https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L434 (and the code hasn't changed in a long time) Created attachment 394122 [details]
Patch
Created attachment 394125 [details]
Patch for landing
Committed r258790: <https://trac.webkit.org/changeset/258790> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394125 [details]. Updated bug title to reflect that commit-queue only skips testing. It never skips building. Although since the builds are incremental, they are usually fast. Also deployed on production server. |