Bug 208936

Summary: [GPU Process] encodeNativeImage() should pass imageSize to GraphicsContext::drawNativeImage()
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: CanvasAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, mmaxfield, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Said Abou-Hallawa 2020-03-11 12:37:39 PDT 
The current call in encodeNativeImage() passes an empty FloatSize for the argument 'imageSize'. This causes the NativeImage not be be drawn to the ShareableBitmap. So encoding the NativeImage was always sending zero image from the WebProcess to the GPUProcess.
Comment 1 Said Abou-Hallawa 2020-03-11 12:44:02 PDT 
Created attachment 393277 [details]
Patch
Comment 2 Said Abou-Hallawa 2020-03-11 12:44:35 PDT 
This patch lowers the failures of the command 

run-webkit-tests --debug --no-retry LayoutTests/canvas/ LayoutTests/fast/canvas  --internal-feature RenderCanvasInGPUProcessEnabled

from 69 to 45 (after the patch of https://bugs.webkit.org/show_bug.cgi?id=208876 and https://bugs.webkit.org/show_bug.cgi?id=208931).
Comment 3 WebKit Commit Bot 2020-03-11 21:25:04 PDT 
Comment on attachment 393277 [details]
Patch

Clearing flags on attachment: 393277

Committed r258312: <https://trac.webkit.org/changeset/258312>
Comment 4 WebKit Commit Bot 2020-03-11 21:25:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-11 21:26:17 PDT 
<rdar://problem/60355796>