Bug 208931

Summary:

[GPU Process] RemoteImageBuffer::getImageData() has to clear its DisplayList after calling flushDrawingContext()

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Canvas

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, mmaxfield, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Said Abou-Hallawa 2020-03-11 11:22:45 PDT

Otherwise the same drawing commands will be replayed back anytime the backend is checked for uncommitted drawing.

Comment 1 Said Abou-Hallawa 2020-03-11 11:27:52 PDT

Created attachment 393269 [details]
Patch

Comment 2 Said Abou-Hallawa 2020-03-11 12:16:42 PDT

This patch lowers the failures of the command 

run-webkit-tests --debug --no-retry LayoutTests/canvas/ LayoutTests/fast/canvas  --internal-feature RenderCanvasInGPUProcessEnabled

from 100 to 68 (after the patch of https://bugs.webkit.org/show_bug.cgi?id=208876).

Comment 3 WebKit Commit Bot 2020-03-11 21:20:03 PDT

Comment on attachment 393269 [details]
Patch

Clearing flags on attachment: 393269

Committed r258311: <https://trac.webkit.org/changeset/258311>

Comment 4 WebKit Commit Bot 2020-03-11 21:20:05 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2020-03-11 21:21:18 PDT

<rdar://problem/60355642>