| Summary: | [PlayStation] incomplete type 'WebCore::ScrollingStateFrameScrollingNode' named in nested name specifier | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Stephan Szabo <stephan.szabo> | ||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, don.olmstead, ews-watchlist, fred.wang, jamesr, koivisto, luiz, ross.kirsling, simon.fraser, tonikitoo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 393178 [details]
Patch
Adding include for ScrollingStateFrameScrollingNode, checking if this is okay on the various EWS bots.
Comment on attachment 393178 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393178&action=review Seems like more than a PS port fix, this is a missing include from r258012? > Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:34 > +#if ENABLE(SCROLLING_THREAD) > +#include "ScrollingStateFrameScrollingNode.h" > +#endif Judging from other CPP files that include this, I think you can probably get away without guarding the include. I'm not sure if anyone else is hitting the code in question with the combination of enable flags, but noticed it from the PlayStation buildbot. I'd figured I'd guard the include to prevent bringing in the full include for cases that were okay with just the forward declaration, but can do it unconditionally. Comment on attachment 393178 [details] Patch Clearing flags on attachment: 393178 Committed r258238: <https://trac.webkit.org/changeset/258238> All reviewed patches have been landed. Closing bug. |
We started seeing errors in the ENABLE(SCROLLING_THREAD) block with: ../../Source/WebCore\page/scrolling/ScrollingTreeScrollingNode.cpp:98:34: error: incomplete type 'WebCore::ScrollingStateFrameScrollingNode' named in nested name specifier if (state.hasChangedProperty(ScrollingStateFrameScrollingNode::ReasonsForSynchronousScrolling))