Bug 208880

Summary: FocusController::setFocusedElement() should tell client of refocused element
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=147836
Attachments:
Description Flags
Patch
none
Patch none

Description Daniel Bates 2020-03-10 13:19:14 PDT 
FocusController::setFocusedElement() should tell the client when an element that is already focused is being asked to become focused again. This allows a client to re-evaluate whether to provide UI assistance to an element (e.g. bring up the keyboard on iOS).
Comment 1 Daniel Bates 2020-03-10 14:04:00 PDT 
Created attachment 393176 [details]
Patch
Comment 2 Daniel Bates 2020-03-10 14:10:01 PDT 
Created attachment 393177 [details]
Patch
Comment 3 Daniel Bates 2020-03-10 14:12:12 PDT 
<rdar://problem/58870777>
Comment 4 Wenson Hsieh 2020-03-11 18:36:59 PDT 
Comment on attachment 393177 [details]
Patch

Seems reasonable to me. What effect (if any) does this have on Speedometer?
Comment 5 Daniel Bates 2020-03-12 09:18:02 PDT 
(In reply to Wenson Hsieh from comment #4)
> Comment on attachment 393177 [details]
> Patch
> 
> Seems reasonable to me. What effect (if any) does this have on Speedometer?

It has no effect on Speedometer: the branch is never hit.
Comment 6 Daniel Bates 2020-03-12 09:18:10 PDT 
Thanks for the review.
Comment 7 Daniel Bates 2020-03-12 09:19:24 PDT 
Comment on attachment 393177 [details]
Patch

Clearing flags on attachment: 393177

Committed r258333: <https://trac.webkit.org/changeset/258333>
Comment 8 Daniel Bates 2020-03-12 09:19:26 PDT 
All reviewed patches have been landed.  Closing bug.