Bug 208870

Summary: [WPE] Several disk-cache tests are flaky since r256967?
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Diego Pino 2020-03-10 10:15:03 PDT
The following became flaky since r256967?:

   http/tests/cache/disk-cache/disk-cache-204-status-code.html [ Failure ]
   http/tests/cache/disk-cache/disk-cache-disable.html [ Failure ]

wk-testhunter shows the tests started to became flaky since:

r256950                       NOERROR
[r256951-r256986]             UNKNOWN
r256987                       TEXT (Expected: PASS)

Within the interval the most likely revision for this regression seems to be r256967 (not bisected).

Diff:

--- /home/dpino/workspace/webkit-wpe/layout-test-results/retries/http/tests/cache/disk-cache/disk-cache-disable-expected.txt
+++ /home/dpino/workspace/webkit-wpe/layout-test-results/retries/http/tests/cache/disk-cache/disk-cache-disable-actual.txt
@@ -6,7 +6,7 @@
 Default (cache enabled)
 --------Testing loads from disk cache--------
 response headers: {"Cache-control":"max-age=100"}
-response source: Disk cache
+response source: Network

 --------Testing loads through memory cache (XHR behavior)--------
 response headers: {"Cache-control":"max-age=100"}
Comment 1 Diego Pino 2020-03-12 06:38:32 PDT
These two other tests are also flaky:

   http/tests/cache/disk-cache/disk-cache-307-status-code.html [ Failure ]
   http/tests/cache/disk-cache/disk-cache-404-status-code.html [ Failure ]

Diff:

--- /home/dpino/workspace/webkit-wpe/layout-test-results/retries/http/tests/cache/disk-cache/disk-cache-307-status-code-expected.txt
+++ /home/dpino/workspace/webkit-wpe/layout-test-results/retries/http/tests/cache/disk-cache/disk-cache-307-status-code-actual.txt
@@ -13,13 +13,13 @@
 response source: Network
 
 response headers: {"Status":"307","Cache-control":"max-age=100"}
-response source: Disk cache
+response source: Network
 
 response headers: {"Status":"307","Expires":"now(0)"}
 response source: Network
 
 response headers: {"Status":"307","Expires":"now(100)"}
-response source: Disk cache
+response source: Network
 
 response headers: {"Status":"307","Last-Modified":"now(-1000)"}
 response source: Network

--- /home/dpino/workspace/webkit-wpe/layout-test-results/retries/http/tests/cache/disk-cache/disk-cache-404-status-code-expected.txt
+++ /home/dpino/workspace/webkit-wpe/layout-test-results/retries/http/tests/cache/disk-cache/disk-cache-404-status-code-actual.txt
@@ -10,10 +10,10 @@
 response source: Network
 
 response headers: {"Status":"404","Cache-control":"max-age=100"}
-response source: Disk cache
+response source: Network
 
 response headers: {"Status":"404","Last-Modified":"now(-1000)"}
-response source: Disk cache
+response source: Network
 
 --------Testing loads through memory cache (XHR behavior)--------
 response headers: {"Status":"404","Cache-control":"max-age=0"}
Comment 2 Diego Pino 2024-01-12 22:44:07 PST
The test(s) filed under this bug ticket have consistently passed for the last 4000 revisions. Currently, there are no more tests in TestExpectations that refer to this bug. Therefore, I'm closing the bug.