| Summary: | WebKitTestRunner bundleID should not be cleared before every test | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||
| Component: | WebKit Misc. | Assignee: | Kate Cheney <katherine_cheney> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, pvollan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Kate Cheney
2020-03-09 10:57:15 PDT
Created attachment 393056 [details]
Patch
Comment on attachment 393056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393056&action=review > Tools/WebKitTestRunner/TestController.cpp:643 > + clearApplicationBundleIdentifierTestingOverride(); What happens with the next test if this is executed? Will it use the new bundle id, or fall back to the one from Info.plist? (In reply to Per Arne Vollan from comment #3) > Comment on attachment 393056 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393056&action=review > > > Tools/WebKitTestRunner/TestController.cpp:643 > > + clearApplicationBundleIdentifierTestingOverride(); > > What happens with the next test if this is executed? Will it use the new > bundle id, or fall back to the one from Info.plist? Every test will start out with the Info.plist bundle ID. It will only be changed from that if a test manually sets the bundleID using TestOptions. Comment on attachment 393056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393056&action=review R=me. >>> Tools/WebKitTestRunner/TestController.cpp:643 >>> + clearApplicationBundleIdentifierTestingOverride(); >> >> What happens with the next test if this is executed? Will it use the new bundle id, or fall back to the one from Info.plist? > > Every test will start out with the Info.plist bundle ID. It will only be changed from that if a test manually sets the bundleID using TestOptions. Sounds good! (In reply to Per Arne Vollan from comment #5) > Comment on attachment 393056 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393056&action=review > > R=me. > > >>> Tools/WebKitTestRunner/TestController.cpp:643 > >>> + clearApplicationBundleIdentifierTestingOverride(); > >> > >> What happens with the next test if this is executed? Will it use the new bundle id, or fall back to the one from Info.plist? > > > > Every test will start out with the Info.plist bundle ID. It will only be changed from that if a test manually sets the bundleID using TestOptions. > > Sounds good! Thanks for the review! Comment on attachment 393056 [details] Patch Clearing flags on attachment: 393056 Committed r258178: <https://trac.webkit.org/changeset/258178> All reviewed patches have been landed. Closing bug. |