| Summary: | Generate commit-queue status bubble from new EWS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=209215 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 201934 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2020-03-09 07:48:14 PDT
Created attachment 393033 [details]
Patch
Sample runs: https://ews.webkit-uat.org/status-bubble/391081/ https://ews.webkit-uat.org/status-bubble/392839/ Comment on attachment 393033 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393033&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:302 > + for queue in StatusBubble.ALL_QUEUES: This part confuses me a bit because it seems to be the inverse of what we had before. Before, we would iterate through all bubbles if there was a patch and is had NOT been sent to Buildbot, now, we iterate through all the bubble is there is a patch and it HAS been sent to Buildbot. Comment on attachment 393033 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393033&action=review >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:302 >> + for queue in StatusBubble.ALL_QUEUES: > > This part confuses me a bit because it seems to be the inverse of what we had before. > > Before, we would iterate through all bubbles if there was a patch and is had NOT been sent to Buildbot, now, we iterate through all the bubble is there is a patch and it HAS been sent to Buildbot. Before, if a patch was not sent to buildbot, we would exit early and display submit-to-ews button. If the patch was sent to buildbot, we would generate all it's bubbles. Should be same now as well. Comment on attachment 393033 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393033&action=review >>> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:302 >>> + for queue in StatusBubble.ALL_QUEUES: >> >> This part confuses me a bit because it seems to be the inverse of what we had before. >> >> Before, we would iterate through all bubbles if there was a patch and is had NOT been sent to Buildbot, now, we iterate through all the bubble is there is a patch and it HAS been sent to Buildbot. > > Before, if a patch was not sent to buildbot, we would exit early and display submit-to-ews button. If the patch was sent to buildbot, we would generate all it's bubbles. Should be same now as well. I'm sorry, you're right, was mis-reading the code. Committed r258198: <https://trac.webkit.org/changeset/258198> All reviewed patches have been landed. Closing bug and clearing flags on attachment 393033 [details]. |