| Summary: | Remove SampleBufferDisplayLayer sync IPC | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2020-03-09 05:00:35 PDT
Created attachment 393022 [details]
Patch
Comment on attachment 393022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393022&action=review r=me if the bots are happy > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:385 > + [m_boundsChangeListener begin: m_sampleBufferDisplayLayer->rootLayer()]; Nit: don't need a space after the ':' Created attachment 393140 [details]
Patch for landing
Comment on attachment 393140 [details] Patch for landing Rejecting attachment 393140 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 393140, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13337675 Created attachment 393145 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 393145 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 393145 [details] Patch for landing Clearing flags on attachment: 393145 Committed r258208: <https://trac.webkit.org/changeset/258208> All reviewed patches have been landed. Closing bug. |