Bug 208802

Summary: Add support for overscroll customization parsing
Product: WebKit Reporter: cathiechen <cathiechen>
Component: ScrollingAssignee: cathiechen <cathiechen>
Status: NEW ---    
Severity: Normal CC: adieulot, annulen, benjamin, calvaris, cdumez, esprehn+autocc, ews-watchlist, fred.wang, gyuyoung.kim, herr.ernst, jbedard, kangil.han, keith_miller, kondapallykalyan, mark.lam, msaboff, ryuan.choi, saam, sergio, simon.fraser, tzagallo, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 201556, 208813, 209134    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description cathiechen 2020-03-09 02:18:15 PDT 
Add support for overscroll customization parsing, compile flag and preference setting.
Comment 1 cathiechen 2020-03-09 08:07:57 PDT 
Created attachment 393035 [details]
Patch
Comment 2 cathiechen 2020-03-09 08:30:25 PDT 
Created attachment 393036 [details]
Patch
Comment 3 cathiechen 2020-03-09 23:09:33 PDT 
Created attachment 393120 [details]
Patch
Comment 4 cathiechen 2020-03-09 23:46:41 PDT 
Created attachment 393122 [details]
Patch
Comment 5 cathiechen 2020-03-09 23:55:48 PDT 
Created attachment 393124 [details]
Patch
Comment 6 Frédéric Wang (:fredw) 2020-03-10 04:04:59 PDT 
Comment on attachment 393124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393124&action=review

LGTM, but please wait to have done more for bug 201556 before landing as for now this is not doing anything.

> Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h:217
> +

unneeded whitespace change
Comment 7 Simon Fraser (smfr) 2020-03-11 14:21:45 PDT 
Comment on attachment 393124 [details]
Patch

OVERSCROLL_CUSTOMIZATION is a weird name for this. Maybe OVERSCROLL_EVENTS?
Comment 8 cathiechen 2020-03-12 09:34:16 PDT 
(In reply to Simon Fraser (smfr) from comment #7)
> Comment on attachment 393124 [details]
> Patch
> 
> OVERSCROLL_CUSTOMIZATION is a weird name for this. Maybe OVERSCROLL_EVENTS?

Done, thanks
Comment 9 cathiechen 2020-03-12 09:34:44 PDT 
Created attachment 393384 [details]
Patch
Comment 10 cathiechen 2020-03-12 10:16:26 PDT 
Created attachment 393388 [details]
Patch
Comment 11 cathiechen 2020-04-09 23:29:53 PDT 
Created attachment 396050 [details]
Patch