| Summary: | CAN_SECURELY_ARCHIVE_FILE_WRAPPER incorrectly excludes watchOS and tvOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | WebKit Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, ews-watchlist, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2020-03-08 15:16:54 PDT
Created attachment 392994 [details]
Patch
Comment on attachment 392994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392994&action=review > Source/WTF/wtf/PlatformUse.h:327 > +#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) macOS version check is also unnecessary, PLATFORM(COCOA) is enough. Comment on attachment 392994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392994&action=review >> Source/WTF/wtf/PlatformUse.h:327 >> +#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) > > macOS version check is also unnecessary, PLATFORM(COCOA) is enough. Ah, I didn’t realize we don’t build for macOS 10.13 updates anymore. In that case, since this only affects Cocoa code (APIAttachmentCocoa.mm), I think the right thing to do is to simply remove the !CAN_SECURELY_ARCHIVE_FILE_WRAPPER codepath. Created attachment 393003 [details]
Just remove CAN_SECURELY_ARCHIVE_FILE_WRAPPER
Comment on attachment 393003 [details] Just remove CAN_SECURELY_ARCHIVE_FILE_WRAPPER Clearing flags on attachment: 393003 Committed r258128: <https://trac.webkit.org/changeset/258128> All reviewed patches have been landed. Closing bug. |