| Summary: | Rename ResourceResponseBase::isHTTP to isInHTTPFamily | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||||||
| Component: | New Bugs | Assignee: | Rob Buis <rbuis> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | cdumez, cgarcia, darin, ews-watchlist, japhet, sam, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Rob Buis
2020-03-08 06:32:30 PDT
Created attachment 392952 [details]
Patch
Comment on attachment 392952 [details]
Patch
Seems OK. Not sure this is an improvement. I would have been tempted to rename it rather than deleting it. Seems logical to check isHTTP() before calling httpStatusCode(), less obvious to check url().protocolIsInHTTPFamily().
WebKitLegacy\win\Plugins\PluginStream.cpp(155,8): error C2039: 'isHTTP': is not a member of 'WebCore::ResourceResponse'
Created attachment 393015 [details]
Patch
(In reply to Darin Adler from comment #2) > Comment on attachment 392952 [details] > Patch > > Seems OK. Not sure this is an improvement. I would have been tempted to > rename it rather than deleting it. Seems logical to check isHTTP() before > calling httpStatusCode(), less obvious to check > url().protocolIsInHTTPFamily(). > > WebKitLegacy\win\Plugins\PluginStream.cpp(155,8): error C2039: 'isHTTP': is > not a member of 'WebCore::ResourceResponse' Build error fixed but also willing to rename (Bug title would need to be updated). isHTTPorHTTPS? isInHTTPFamily? Or even protocolIsInHTTPFamily to match URL? Created attachment 400660 [details]
Patch
Created attachment 400661 [details]
Patch
ChangeLog entry in Source/WebKitLegacy/win/ChangeLog contains OOPS!. Created attachment 400725 [details]
Patch
Committed r262369: <https://trac.webkit.org/changeset/262369> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400725 [details]. |