Bug 208763

Summary: Add runtime flag for incremental PDF loading
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: ASSIGNED ---    
Severity: Normal CC: achristensen, cdumez, commit-queue, ggaren, mjs, rniwa, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
thorton: review+, thorton: commit-queue-
PFL
none
PFL none

Description Brady Eidson 2020-03-07 08:40:56 PST 
Add runtime flag for incremental PDF loading
Comment 1 Brady Eidson 2020-03-07 08:57:59 PST 
Created attachment 392861 [details]
Patch
Comment 2 Brady Eidson 2020-03-07 09:01:13 PST 
Created attachment 392862 [details]
Patch
Comment 3 Tim Horton 2020-03-07 11:10:02 PST 
Comment on attachment 392862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392862&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:330
> +    bool m_incredmentalPDFLoadingEnabled;

INCRED-mental
Comment 4 Brady Eidson 2020-03-07 13:25:38 PST 
(In reply to Tim Horton from comment #3)
> Comment on attachment 392862 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392862&action=review
> 
> > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:330
> > +    bool m_incredmentalPDFLoadingEnabled;
> 
> INCRED-mental

I don't always write patches on the weekends while watching both kids, but when I do, The Incredibles is often on in the background.
Comment 5 Brady Eidson 2020-03-07 13:26:50 PST 
Created attachment 392884 [details]
PFL
Comment 6 Brady Eidson 2020-03-07 13:30:05 PST 
Created attachment 392885 [details]
PFL
Comment 7 WebKit Commit Bot 2020-03-07 14:13:21 PST 
Comment on attachment 392885 [details]
PFL

Clearing flags on attachment: 392885

Committed r258080: <https://trac.webkit.org/changeset/258080>