Bug 208757

Summary: generate-bindings-all.pl: "my" variable $fh masks earlier declaration in same scope
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebCore Misc.Assignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, ews-watchlist, fujii.hironori, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

David Kilzer (:ddkilzer)
Reported 2020-03-06 20:56:55 PST
Noticed here: <https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/16615/steps/compile-webkit/logs/stdio> [...] Updating WinCairoRequirements.zip... Found existing release: v2020.01.21 Seeking latest release from WebKitForWindows/WinCairoRequirements... Found release to download: v2020.01.21 Already up-to-date! [0/460] Generate bindings (WebCoreBindings) "my" variable $fh masks earlier declaration in same scope at C:/WebKit-BuildWorker/wincairo-wkl-release/build/Source/WebCore/bindings/scripts/generate-bindings-all.pl line 75. Preprocess IDL [2/219] cmd.exe /C "cd /D C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release && C:\tools\cmake\bin\cmake.exe -E copy_directory C:/WebKit-BuildWorker/wincairo-wkl-release/build/Source/WebInspectorUI/UserInterface C:/WebKit-BuildWorker/wincairo-wkl-release/build/WebKitBuild/Release/bin64/WebKit.resources/WebInspectorUI && C:\tools\cmake\bin\cmake.exe -E copy C:/WebKit-BuildWorker/wincairo-wkl-release/build/WebKitBuild/Release/JavaScriptCore/DerivedSources/inspector/InspectorBackendCommands.js C:/WebKit-BuildWorker/wincairo-wkl-release/build/WebKitBuild/Release/bin64/WebKit.resources/WebInspectorUI/Protocol && C:\tools\cmake\bin\cmake.exe -E copy C:/WebKit-BuildWorker/wincairo-wkl-release/build/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js C:/WebKit-BuildWorker/wincairo-wkl-release/build/WebKitBuild/Release/bin64/WebKit.resources/WebInspectorUI" [3/219] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebHistoryItem.cpp.obj [4/219] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebKitDLL.cpp.obj [5/219] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\WebKit\DerivedSources\DownloadProxyMessageReceiver.cpp.obj [...]
Attachments
Patch (1.40 KB, patch)
2020-03-07 23:48 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-03-07 17:16:26 PST
introduced by r257975 (Bug 205107).
Fujii Hironori
Comment 2 2020-03-07 17:17:59 PST
Not only WinCairo port, but all CMake ports. https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/30850/steps/compile-webkit/logs/stdio > "my" variable $fh masks earlier declaration in same scope at /home/slave/webkitgtk/gtk-linux-64-release/build/Source/WebCore/bindings/scripts/generate-bindings-all.pl line 75.
Fujii Hironori
Comment 3 2020-03-07 23:48:38 PST
Created attachment 392943 [details] Patch
Yusuke Suzuki
Comment 4 2020-03-08 01:16:12 PST
Comment on attachment 392943 [details] Patch r=me
WebKit Commit Bot
Comment 5 2020-03-08 13:32:17 PDT
The commit-queue encountered the following flaky tests while processing attachment 392943 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 160571 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-03-08 13:32:55 PDT
Comment on attachment 392943 [details] Patch Clearing flags on attachment: 392943 Committed r258112: <https://trac.webkit.org/changeset/258112>
WebKit Commit Bot
Comment 7 2020-03-08 13:32:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-03-08 13:33:12 PDT
<rdar://problem/60203979>
Note You need to log in before you can comment on or make changes to this bug.