Bug 208752

Summary: [Media in GPU Process] Implement caption support in video fullscreen and PiP
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, jer.noble, kangil.han, kondapallykalyan, pdr, philipj, sergio, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 216829    
Bug Blocks:    
Attachments:
Description Flags
WIP patch
simon.fraser: review-
Patch
ews-feeder: commit-queue-
Fix build failures on WPE and GTK ports
ews-feeder: commit-queue-
Fix build failures on WPE and GTK ports v2
none
Fix build failures again none

Description Peng Liu 2020-03-06 18:17:58 PST 
[Media in GPU Process] Implement caption support in video fullscreen and PiP
Comment 1 Peng Liu 2020-03-06 19:04:16 PST 
<rdar://problem/60178102>
Comment 2 Peng Liu 2020-03-06 22:37:19 PST 
Created attachment 392849 [details]
WIP patch
Comment 3 Simon Fraser (smfr) 2020-03-07 08:19:07 PST 
Comment on attachment 392849 [details]
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392849&action=review

> Source/WebCore/dom/Document.cpp:2103
> +        // ASSERT_NOT_REACHED();

You cannot remove this. If this hits, you're doing something wrong.

> Source/WebCore/rendering/RenderLayer.cpp:5703
> +            // ASSERT(clipRectsContext.rootLayer == m_clipRectsCache->m_clipRectsRoot[clipRectsType]);
> +            // ASSERT(m_clipRectsCache->m_scrollbarRelevancy[clipRectsType] == clipRectsContext.overlayScrollbarSizeRelevancy);

If you're hitting these you're also doing something wrong.
Comment 4 Peng Liu 2020-09-22 15:43:15 PDT 
Created attachment 409415 [details]
Patch
Comment 5 Peng Liu 2020-09-22 15:49:28 PDT 
Created attachment 409416 [details]
Fix build failures on WPE and GTK ports
Comment 6 Peng Liu 2020-09-22 16:01:34 PDT 
Created attachment 409418 [details]
Fix build failures on WPE and GTK ports v2
Comment 7 Peng Liu 2020-09-22 16:17:46 PDT 
Created attachment 409420 [details]
Fix build failures again
Comment 8 Eric Carlson 2020-09-23 11:00:59 PDT 
Comment on attachment 409420 [details]
Fix build failures again

View in context: https://bugs.webkit.org/attachment.cgi?id=409420&action=review

> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:154
> +#if PLATFORM(IOS_FAMILY)
> +    if (decoder.messageReceiverName() == Messages::RemoteMediaSessionHelper::messageReceiverName()) {
> +        // FIXME
> +        return true;
> +    }
> +#endif

It might make more sense to add this when we fix RemoteMediaSessionHelper.
Comment 9 Peng Liu 2020-09-23 11:24:11 PDT 
Comment on attachment 409420 [details]
Fix build failures again

View in context: https://bugs.webkit.org/attachment.cgi?id=409420&action=review

>> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:154
>> +#endif
> 
> It might make more sense to add this when we fix RemoteMediaSessionHelper.

Agree. But there will be assertion failures if we don't add it. :-(
Comment 10 EWS 2020-09-23 11:45:16 PDT 
Committed r267491: <https://trac.webkit.org/changeset/267491>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409420 [details].