| Summary: | Add "AndOrdered" to the names of ordered DoubleConditions. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=208731 | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2020-03-06 14:44:55 PST
Created attachment 392832 [details]
proposed patch.
Comment on attachment 392832 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=392832&action=review > Source/JavaScriptCore/ChangeLog:19 > + Renamed the following: > + DoubleEqual ==> DoubleEqualAndOrdered > + DoubleNotEqual ==> DoubleNotEqualAndOrdered > + DoubleGreaterThan ==> DoubleGreaterThanAndOrdered > + DoubleGreaterThanOrEqual ==> DoubleGreaterThanOrEqualAndOrdered > + DoubleLessThan ==> DoubleLessThanAndOrdered > + DoubleLessThanOrEqual ==> DoubleLessThanOrEqualAndOrdered > + > + The comment for these enums in MacroAssemblerARM64.h says: > + // These conditions will only evaluate to true if the comparison is ordered - i.e. neither operand is NaN. > + > + Adding "AndOrdered" to their names makes this property explicit. Isn't this sort of implied? Comment on attachment 392832 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=392832&action=review r=me. >> Source/JavaScriptCore/ChangeLog:19 >> + Adding "AndOrdered" to their names makes this property explicit. > > Isn't this sort of implied? Can you note that this is interesting because on most CPUs DoubleNotEqual is DoubleNotEqualOrUnordered? (In reply to Keith Miller from comment #3) > Can you note that this is interesting because on most CPUs DoubleNotEqual is > DoubleNotEqualOrUnordered? Added. Thanks for the review. Landed in r258063: <http://trac.webkit.org/r258063>. |