Bug 208733

Summary: Evaluating JavaScript in main frame before loading should succeed
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, beidson, cdumez, commit-queue, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208767
Attachments:
Description Flags
Patch none

Description Alex Christensen 2020-03-06 13:37:40 PST
Evaluating JavaScript in main frame before loading should succeed
Comment 1 Alex Christensen 2020-03-06 13:39:27 PST
Created attachment 392765 [details]
Patch
Comment 2 Tim Horton 2020-03-06 14:04:18 PST
Comment on attachment 392765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392765&action=review

> Source/WebKit/ChangeLog:8
> +        This fixes a bug in the SPI I introduced in r257882 with a test.

And what is the bug! Why not write like 10 more words? :D
Comment 3 Alex Christensen 2020-03-06 14:05:03 PST
Comment on attachment 392765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392765&action=review

>> Source/WebKit/ChangeLog:8
>> +        This fixes a bug in the SPI I introduced in r257882 with a test.
> 
> And what is the bug! Why not write like 10 more words? :D

The title is that description.  It only needed 9 words.
Comment 4 WebKit Commit Bot 2020-03-06 17:35:46 PST
Comment on attachment 392765 [details]
Patch

Clearing flags on attachment: 392765

Committed r258042: <https://trac.webkit.org/changeset/258042>
Comment 5 WebKit Commit Bot 2020-03-06 17:35:47 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-03-06 17:36:18 PST
<rdar://problem/60177714>
Comment 7 Aakash Jain 2020-03-07 11:27:04 PST
> Committed r258042: <https://trac.webkit.org/changeset/258042>
This seems to have broken API test TestWebKitAPI.URLSchemeHandler.Frames, tracked in Bug 208733.

This was also indicated by EWS in https://ews-build.webkit.org/#/builders/9/builds/18987
Comment 8 Aakash Jain 2020-03-07 11:28:26 PST
Tracked in Bug 208767.